The config_translation module uses test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.

See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because this is a coding standards change.
Issue priority Not critical because coding standard changes are not critical.
Unfrozen changes Unfrozen because it only changes automated tests.
Disruption There is no disruption expected from this sort of change.
CommentFileSizeAuthor
#3 interdiff-1-3.txt826 byteshussainweb
#3 clean_up_config_translation-2396739-3.patch10.28 KBhussainweb
#1 clean_up_config_translation-2396739-1.patch10.76 KBhussainweb

Comments

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new clean_up_config_translation-2396739-1.patch10.76 KB
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Needs work 
+++ b/core/modules/config_translation/src/Tests/ConfigTranslationUiTest.php
@@ -28,7 +28,7 @@ class ConfigTranslationUiTest extends WebTestBase {
    * @var array
    */
-  public static $modules = array('node', 'contact', 'contact_test', 'config_translation', 'config_translation_test', 'views', 'views_ui', 'contextual', 'filter', 'filter_test');
+  public static $modules = ['node', 'contact', 'contact_test', 'config_translation', 'config_translation_test', 'views', 'views_ui', 'contextual', 'filter', 'filter_test'];

So this change is out of scope.

It also violates the coding standards. This array is longer than 80 characters, so it can't be on one line.

Because your change is out of scope, and because your change violates coding standards, I'm not supposed to RTBC it.

phpcs says there aren't any camel case problems, so I'd be able to RTBC if this change weren't present.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new clean_up_config_translation-2396739-3.patch10.28 KB
new interdiff-1-3.txt826 bytes

Removing the change mentioned in #2. Thanks for the review.

tibbsa’s picture

tibbsa commented
Status: Needs review » Reviewed & tested by the community

Testbot is happy and there do not appear to be any additional undeclared variables. The changes made are within the scope of the issue, and this addresses the feedback at #2. RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Looks like Alex has been committing others of these, so joining the club. :P

Committed and pushed to 8.0.x. Thanks!

  • webchick committed dee657a on 8.0.x 
    Issue #2396739 by hussainweb, Mile23: Clean-up config_translation module...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.