The path module uses test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.

See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because this is a coding standards change.
Issue priority Not critical because coding standard changes are not critical.
Unfrozen changes Unfrozen because it only changes automated tests.
Disruption There is no disruption expected from this sort of change.
CommentFileSizeAuthor
#1 clean_up_path_module-2396707-1.patch1.43 KBhussainweb

Comments

hussainweb’s picture

Status: Active » Needs review
StatusFileSize
new1.43 KB

Renamed web_user to webUser.

tibbsa’s picture

Status: Needs review » Reviewed & tested by the community

This patch applies locally, is passing Testbot, and appears to resolve the one case of a class property that required renaming. No other undeclared properties were found. RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: clean_up_path_module-2396707-1.patch, failed testing.

hussainweb’s picture

Status: Needs work » Reviewed & tested by the community

Setting back to RTBC after random fail.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Looks like Alex has been committing others of these, so joining the club. :P

Committed and pushed to 8.0.x. Thanks!

  • webchick committed e558709 on 8.0.x
    Issue #2396707 by hussainweb: Clean-up path module test members - ensure...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.