The options module uses test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.
See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.
| Issue category | Task, because this is a coding standards change. |
|---|---|
| Issue priority | Not critical because coding standard changes are not critical. |
| Unfrozen changes | Unfrozen because it only changes automated tests. |
| Disruption | There is no disruption expected from this sort of change. |
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | clean_up_options_module-2396701-3.patch | 18.04 KB | hussainweb |
| #3 | interdiff-1-3.txt | 951 bytes | hussainweb |
| #1 | clean_up_options_module-2396701-1.patch | 18.04 KB | hussainweb |
Comments
Comment #1
hussainwebRenaming or removing properties as appropriate.
Comment #3
hussainwebRefactoring woes... :(
Comment #4
mile23phpcs says no camel case errors in test classes.
Comment #5
webchickLooks like Alex has been committing others of these, so joining the club. :P
Committed and pushed to 8.0.x. Thanks!