The link module uses test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.
See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.
Beta phase evaluation
| Issue category | Task, because this is a coding standards change. |
|---|---|
| Issue priority | Not critical because coding standard changes are not critical. |
| Unfrozen changes | Unfrozen because it only changes automated tests. |
| Disruption | There is no disruption expected from this sort of change. |
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | clean_up_link_module-2396695-1.patch | 1.84 KB | hussainweb |
Comments
Comment #1
hussainwebRemoved property definitions in two tests as they were only used in the setUp method.
Comment #2
mile23This patch really only removes class properties which are unneeded because they're only used in setUp().
Also, phpcs tells me that there are no camel case errors for test classes.
Comment #3
webchickLooks like Alex has been committing others of these, so joining the club. :P
Committed and pushed to 8.0.x. Thanks!