The language module uses test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.
See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.
| Issue category | Task, because this is a coding standards change. |
|---|---|
| Issue priority | Not critical because coding standard changes are not critical. |
| Unfrozen changes | Unfrozen because it only changes automated tests. |
| Disruption | There is no disruption expected from this sort of change. |
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | clean_up_language-2396691-1.patch | 1.35 KB | hussainweb |
Comments
Comment #1
hussainwebRenaming web_user to webUser and adding property definition. There is an usage of root_user under LanguageConfigOverrideImportTest but that is from WebTestBase.
Comment #2
mile23phpcs says that the patch in #1 fixes camel case errors in test classes.
Comment #5
hussainwebSetting back to RTBC from #2 after random failure.
Comment #6
webchickLooks like Alex has been committing others of these, so joining the club. :P
Committed and pushed to 8.0.x. Thanks!