Clean-up image module test members - ensure property definition and use of camelCase naming convention

Using phpcs I determined that this patch changes all under_score class property names to camelCase for image module's simpletests.

Back to RTBC.

+++ b/core/modules/image/src/Tests/ImageFieldDisplayTest.php
@@ -17,8 +17,6 @@
-  protected $dumpHeaders = TRUE;

This is used... see WebTestBase::$dumpHeader. This was added by #2204159: (Responsive) Image styles do not add correct cache tags, nor do they invalidate cache tags upon flushing to help debug this test when things go wrong.

Also, I am just thinking: Isn't it better to set this value in code in setUp() and avoid all confusion?

Yes, it's overloading the existing property, so it should be an assignment to TRUE in setUp() instead, without a declaration in this class.

Here's something to copy paste and modify as you see fit. I'd make a patch but then I can't review.

  /**
   * {@inheritdoc}
   */
  public function setUp() {
    // Use WebTestBase::dumpHeaders to help us identify bugs while writing tests.
    $this->dumpHeaders = TRUE;
  }

The rest is RTBC.

You're right... There are 7 of them in different modules including this one. Let's handle it in your follow-up: #2406669: Set dumpHeaders property in setUp method rather than while overriding the property in class definition

In that case the docblock for dumpHeaders is out of scope here. :-) One more go-round and it's RTBC time.

phpcs says there aren't any class properties with underscore names.

It does complain about a bunch of local variables with camel case names, but that's out of scope of this issue.

And as per @alexpott in #8, we've addressed the issue of $dumpHeaders in #2406669: Set dumpHeaders property in setUp method rather than while overriding the property in class definition

Woot.

Committed 9fd145f and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation to the issue summary.