The history module uses test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.

See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because this is a coding standards change.
Issue priority Not critical because coding standard changes are not critical.
Unfrozen changes Unfrozen because it only changes automated tests.
Disruption There is no disruption expected from this sort of change.
CommentFileSizeAuthor
#1 2396657_1.patch1.17 KBmile23

Comments

mile23’s picture

Assigned: mile23 » Unassigned
StatusFileSize
new1.17 KB

Changed test_node in HistoryTest to be testNode.

tibbsa’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies cleanly to HEAD, and addresses the camelCase problem identified by this issue. No other properties seem to have been missed. RTBC.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Looks like Alex has been committing others of these, so joining the club. :P

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 33c0894 on 8.0.x
    Issue #2396657 by Mile23: Clean-up history module test members - ensure...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.