Latest release: https://github.com/aFarkas/html5shiv

CommentFileSizeAuthor
#3 html5shiv-min-2396307-3.patch7.05 KBdroplet
html5shiv.min_.patch6.11 KBdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, html5shiv.min_.patch, failed testing.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs work » Needs review
FileSize
html5shiv-min-2396307-3.patch7.05 KB

Cool. the failing shown us that bowerjs like tools may not help to manage libs updates, LOL.

nod_ queued 3: html5shiv-min-2396307-3.patch for re-testing.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

All good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/assets/vendor/html5shiv/html5shiv.min.js
@@ -0,0 +1,4 @@
\ No newline at end of file

Have we agreed that minified files should not have a newline at the end of file. This seems like a bad idea to me.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs work » Reviewed & tested by the community

minified files may get from vendor repo directly that's no new lines

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Upgrading core's dependencies is allowed during beta. Committed 9722028 and pushed to 8.0.x. Thanks!

                // Append a ';' and a newline after each JS file to prevent them
                // from running together.
                $data .= ";\n";

In JsCollectionOptimizer allays my fears.

  • alexpott committed 9722028 on 8.0.x 
    Issue #2396307 by droplet: Update JS lib: html5shiv to 3.7.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.