Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
simpletest.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Dec 2014 at 02:39 UTC
Updated:
14 Mar 2015 at 22:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tstoecklerHere we go. This still needs (automated) tests, but I verified that this works locally.
Comment #2
tstoecklerSo this was reported by @chx, who needs this to be able to properly test the MongoDB suite. As mentioned in #2229011: Tests are no longer modifiable there are other possible use-cases (those apply to
KernelTestBasetests as much asWebTestBase).Also note that it's totally my fault that this currently does not work. I implemented the
testing.services.ymlsupport forKernelTestBasetests in the referenced issue, but I cannot fathom why I stopped at the halfway mark.Comment #4
tstoecklerDon't want to keep anyone from working on this, but keeping this on my radar.
Comment #5
dawehner--- nevermind everything is alright ---
Comment #6
dawehnerTried to write some test but so far no success.
Comment #7
chx commentedBroken reroll.
Comment #9
chx commentedRerolled at least. Needs review indeed.

Also this is what I get with mongodb:
Comment #11
tstoecklerThanks! This being assigned to me is a lie at this point... ..sadly. Hope I manage to get back to this soon.
Comment #12
chx commentedOK this is the minimal disruption version: if there are no overrides, no change happens. At all.
Comment #13
chx commentedAaaargh wrong patch. Too many development directories!
Comment #15
dawehnerSo what about something like that? Note: This is some logic more similar to the one in WebTestBase but yeah, we don't cover all lines of code.
Comment #16
tstoecklerThe test looks great. It should generally be sufficient in terms of coverage IMO although
SimpleTestTestcontainsin the test settings.testing.php. I think that could easily be added here without any further assertions.
I have one minor nitpick:
The variable names are a bit confusing, because the first is a filepath and the second are the file contents but the names are very similar.
Comment #17
chx commentedComment #18
dawehnerLooks perfect now!
Comment #20
tstoecklerAwesome, thanks!
Comment #21
webchickMakes sense. That
+ $php = <<<'EOS'stuff is wackadoo, but apparently we do this elsewhere in HEAD according to grep.Eyeballing WebTestBase.php, this seems to cover the same bases, and has been RTBC for awhile if anyone had any other concerns.
Committed and pushed to 8.0.x. Thanks!
Comment #23
chx commented