Some of Bartik's Twig templates contain comments indicating the closing tags for each HTML element in the template.
For example here is the end of the page.html.twig file...

          </div> <!-- /#footer -->
        {% endif %}
      </footer> <!-- /.section -->
    </div> <!-- /#footer-wrapper -->
  </div> <!-- /#page -->
</div> <!-- /#page-wrapper -->

No other theme follows this practice and with work such as #1903048: Revise Bartik template indentation inline with best practices. you can clearly see from just structuring the code correctly what belongs to what.

These comments also print in the frontend when you look at the markup. It looks like we haven't tidied up after ourselves and we want to show a good example with Bartik.

Please can the <!--/ .... > comments be removed.

Beta phase evaluation

-->

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it is removing comments from template files, these end tag comments are not part of coding standards.
Issue priority Not critical because code cleanup
Unfrozen changes Unfrozen because it only removes comments from templates.
Files: 
CommentFileSizeAuthor
#10 remove_closing_tag-2395825-10.patch5.37 KBDickJohnson
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,561 pass(es). View
#6 remove_closing_tag-2395825-6.patch.diff5.17 KBjennyOlsen
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,537 pass(es). View
#4 Screen Shot 2014-12-18 at 22.44.10.png91.7 KBemma.maria

Comments

emma.maria’s picture

Issue summary: View changes
emma.maria’s picture

Issue summary: View changes
emma.maria’s picture

Issue summary: View changes
emma.maria’s picture

Issue summary: View changes
FileSize
91.7 KB
jennyOlsen’s picture

Assigned: Unassigned » jennyOlsen
jennyOlsen’s picture

FileSize
5.17 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,537 pass(es). View

Attached patch removes the html comments from the Bartik template files

jennyOlsen’s picture

Assigned: jennyOlsen » Unassigned
Cottser’s picture

Status: Active » Needs review

Setting to needs review so the patch gets tested :)

joelpittet’s picture

Status: Needs review » Postponed

It's going to conflict a bit with #1903048: Revise Bartik template indentation inline with best practices. so postpone on that one, unless you want to RTBC them both and just re-roll after commit?

DickJohnson’s picture

Status: Postponed » Needs review
FileSize
5.37 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,561 pass(es). View
LewisNyman’s picture

Status: Needs review » Reviewed & tested by the community

I had a quick check to make sure that the indentations were not changed by the patch and they aren't! Thanks

emma.maria’s picture

I manually compared templates side by side and comments are removed with no changes or breaks to anything else. RTBC++

emma.maria’s picture

Issue summary: View changes

Added the Beta evaluation to the issue summary.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed a92c3a1 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.

  • alexpott committed a92c3a1 on 8.0.x
    Issue #2395825 by emma.maria, jennyOlsen, DickJohnson: Remove closing...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.