When configuration is renamed the static cache is not properly cleared of all instances of the configuration.

Files: 
CommentFileSizeAuthor
#8 2395511.8.patch2.33 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,785 pass(es). View
#8 interdiff.txt1.52 KBGábor Hojtsy
#1 2395511.1.patch2.26 KBalexpott
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,535 pass(es). View
#1 2395511.1-test-only.patch1.57 KBalexpott
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,550 pass(es), 1 fail(s), and 0 exception(s). View

Comments

alexpott’s picture

Status: Active » Needs review
FileSize
1.57 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,550 pass(es), 1 fail(s), and 0 exception(s). View
2.26 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,535 pass(es). View

The last submitted patch, 1: 2395511.1-test-only.patch, failed testing.

Wim Leers’s picture

Status: Needs review » Needs work

I could not find any flaws, except for nitpicks. Looks ready to me.

  1. +++ b/core/modules/config/src/Tests/ConfigCRUDTest.php
    @@ -117,13 +117,26 @@ function testCRUD() {
    +    // Pollute the non overrides static cache.
    ...
    +    // Ensure the non overrides static cache has been cleared.
    

    s/non overrides/non-overrides/

  2. +++ b/core/modules/config/src/Tests/ConfigCRUDTest.php
    @@ -117,13 +117,26 @@ function testCRUD() {
    +    $config_factory->setOverrideState(TRUE);
    

    Could use a symmetrical comment, like "Restore overrides".

  3. +++ b/core/modules/config/src/Tests/ConfigCRUDTest.php
    @@ -117,13 +117,26 @@ function testCRUD() {
         $new_name = 'config_test.crud_rename_no_cache';
    

    Could perhaps using a comment above it, to indicate that this is where the *actual* renaming happens, and the testing of that?

alexpott’s picture

Status: Needs work » Needs review
alexpott’s picture

Status: Needs review » Needs work
Gábor Hojtsy’s picture

Priority: Major » Critical
Gábor Hojtsy’s picture

Agreed with Wim, looks good. One more nit:

+++ b/core/modules/config/src/Tests/ConfigCRUDTest.php
@@ -117,13 +117,26 @@ function testCRUD() {
+    // Remove overrides.

Turn off overrides? (We don't actually remove them).

Gábor Hojtsy’s picture

Status: Needs work » Needs review
FileSize
1.52 KB
2.33 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 82,785 pass(es). View

Patch with those suggestions applied.

Wim Leers’s picture

Status: Needs review » Reviewed & tested by the community

Looks great :)

  • catch committed a9b064c on 8.0.x
    Issue #2395511 by alexpott, Gábor Hojtsy: Config static cache is not...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.