Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When configuration is renamed the static cache is not properly cleared of all instances of the configuration.
Comment | File | Size | Author |
---|---|---|---|
#8 | 2395511.8.patch | 2.33 KB | Gábor Hojtsy |
#8 | interdiff.txt | 1.52 KB | Gábor Hojtsy |
#1 | 2395511.1.patch | 2.26 KB | alexpott |
#1 | 2395511.1-test-only.patch | 1.57 KB | alexpott |
Comments
Comment #1
alexpottComment #3
Wim LeersI could not find any flaws, except for nitpicks. Looks ready to me.
s/non overrides/non-overrides/
Could use a symmetrical comment, like "Restore overrides".
Could perhaps using a comment above it, to indicate that this is where the *actual* renaming happens, and the testing of that?
Comment #4
alexpottComment #5
alexpottComment #6
Gábor HojtsyCritical due to #2392319-19: Config objects (but not config entities) should by default be immutable by @alexpott.
Comment #7
Gábor HojtsyAgreed with Wim, looks good. One more nit:
Turn off overrides? (We don't actually remove them).
Comment #8
Gábor HojtsyPatch with those suggestions applied.
Comment #9
Wim LeersLooks great :)
Comment #11
catchCommitted/pushed to 8.0.x, thanks!