The field_ui module uses test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.
See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.
| Issue category | Task, because this is a coding standards change. |
|---|---|
| Issue priority | Not critical because coding standard changes are not critical. |
| Unfrozen changes | Unfrozen because it only changes automated tests. |
| Disruption | There is no disruption expected from this sort of change. |
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | clean_up_field_ui-2394417-20.patch | 22.96 KB | hussainweb |
| #13 | clean_up_field_ui-2394417-13.patch | 22.96 KB | hussainweb |
| #13 | interdiff-11-13.txt | 696 bytes | hussainweb |
Comments
Comment #1
tibbsa commentedThere remains one instance of $this->root_user, but that will have to change as part of the Simpletest updates.
Comment #2
tibbsa commentedComment #3
mile23Patch applies, phpcs says there aren't any test class camel case issues. Will re-run the testbot since the last run is a little stale. RTBC after that.
Comment #7
mile23Patch still applies... Let's see if it passes the testbot... Again.
Comment #9
mile23Still happy and green. Re-RTBC from #3.
Comment #10
alexpottNeeds a reroll
Comment #11
sivaji_ganesh_jojodae commentedPatch #1 re-rolled.
Comment #13
hussainwebFixing the error.
Comment #14
mile23phpcs says no more underscore errors. Test passes, patch applies.
Comment #16
mile23The test failure said:
Filter by username returned the right amount. Other UserAdminTest.php 69 Drupal\user\Tests\UserAdminTest->testUserAdmin()I'll retest, because I think this test is unrelated.
Comment #18
mile23Patch still looks good, all the way back from #3, through all the rerolls.
Comment #20
hussainwebStraight reroll...
Comment #21
hussainwebMarking it as RTBC as per #18 and #3 before that. It was a straight reroll, so another review is probably not needed.
Comment #22
alexpottCommitted c9e1f93 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation to the issue summary.