Problem/Motivation

Forms that allow users to change configuration should use ConfigFormBase and not FormBase. This is because ConfigFormBase takes care to not let global and module overrides to pollute the saved configuration.

Proposed resolution

Change forms to use ConfigFormBase

Remaining tasks

Write patch
Review
Commit

User interface changes

None

API changes

None

CommentFileSizeAuthor
#1 2393765.1.patch3.38 KBalexpott

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2393765.1.patch3.38 KB
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Looks like a trivial change and makes sense. #2392319: Config objects (but not config entities) should by default be immutable will add coverage and will be able to find similar cases elsewhere, eg. in contrib. But these changes look good and makes sense to commit on their own.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 26dfabc on 8.0.x 
    Issue #2393765 by alexpott: Several forms should use ConfigFormBase and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.