Code formatting/build scripts changes only, @see: https://github.com/malsup/form/compare/3.50...3.51

CommentFileSizeAuthor
#11 core-js-jqueryform-2393713-11.patch60.83 KBnod_
#9 jquery.form_.min_.patch60.86 KBdroplet
jquery.form_.patch60.79 KBdroplet

Comments

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

That works, thanks!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, jquery.form_.patch, failed testing.

Status: Needs work » Needs review

droplet queued jquery.form_.patch for re-testing.

droplet’s picture

droplet commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs review

@droplet or @nod_ how are we minifying the script - so I can compare to source just to double check?

droplet’s picture

droplet commented

this is from http://closure-compiler.appspot.com/home

nod_ queued jquery.form_.patch for re-testing.

stefan.r queued jquery.form_.patch for re-testing.

droplet’s picture

droplet commented
StatusFileSize
new jquery.form_.min_.patch60.86 KB

Preferred uglify ? OK. this is a reroll of jQuery.form standard build way: https://github.com/malsup/form/blob/master/gulpfile.js

jibran queued 9: jquery.form_.min_.patch for re-testing.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new core-js-jqueryform-2393713-11.patch60.83 KB

Rerolled, just added " " to the library version.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Woot woot.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 53c8046 on 8.0.x 
    Issue #2393713 by droplet, nod_: Update JS lib: jquery.form to 3.5.1

Status: Fixed » Needs work

The last submitted patch, 11: core-js-jqueryform-2393713-11.patch, failed testing.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Fixed

I guess that's what append when patch gets committed before testing.

Status: Fixed » Needs review

nod_ queued 11: core-js-jqueryform-2393713-11.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 11: core-js-jqueryform-2393713-11.patch, failed testing.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.