Problem/Motivation

In #2121713: Move drupal_html_id() and drupal_html_class() to Drupal\Component\Utility, HTML-related code was moved into a utility class under the Component namespace.

Somehow the unit tests ended up under the Core namespace.

Furthermore, in #2294503: Component Utilities unit test cleanups. some extra tests were created for the Html class.

Proposed resolution

Move the tests to the Component namespace.

Remaining tasks

User interface changes

API changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Unfrozen changes Unfrozen because it fixes a namespace error in automated tests.
CommentFileSizeAuthor
#1 2392673_1.patch713 bytesMile23
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
FileSize
2392673_1.patch713 bytes

Moves Drupal\Tests\Core\Utility\HtmlTest to Drupal\Tests\Component\Utility\HtmlTest, updates namespaces and docblocks.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Active » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Looks pretty straightforward and issue summary already has beta eval, great!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: 2392673_1.patch, failed testing.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs work » Needs review

SessionTest, the unrelated test failing above, passes locally, so I'm re-testing.

Mile23 queued 1: 2392673_1.patch for re-testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

Alright.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed eb9e9e3 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.

  • alexpott committed eb9e9e3 on 8.0.x 
    Issue #2392673 by Mile23: Move Drupal\Tests\Core\Utility\HtmlTest to the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.