Due to the shorter widths of the password fields between 768px to 1010px the email address title field takes it upon himself to go sit next to them.

Plus a screenshot in Ubuntu that I took from #2227121: The "Default country" dropdown element overflows the installer container at certain widths.

This only happens in the Firefox browser in every operating system.

I keep spotting it when I test other issues, it would be good to add a super quick fix for this.

First documented here #2227121: The "Default country" dropdown element overflows the installer container at certain widths. and taken out to be fixed in this issue

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug
Unfrozen changes Unfrozen because it only changes CSS
CommentFileSizeAuthor
#7 Screen Shot 2014-12-17 at 15.25.20.jpg470.9 KBlewisnyman
#7 Screen Shot 2014-12-17 at 15.23.34.jpg393.97 KBlewisnyman
#5 FF_33_Windows_1010px.png454.9 KBemma.maria
#5 FF_33_Mac_1010px.png379.79 KBemma.maria
#5 ie9_768px.png180.51 KBemma.maria
#5 Chrome_39_Windows.png313.66 KBemma.maria
#5 Chrome_39_Mac_768px.png406.38 KBemma.maria
#5 FF_33_Windows_768px.png213.74 KBemma.maria
#5 FF_33_Mac_768px.png418.81 KBemma.maria
#2 email-fields-reqstar-moves-up-2392487-2.patch395 bytesDickJohnson
firefox1024_patch.png59.15 KBemma.maria
FF33_Mac.png656.38 KBemma.maria
FF33_PC.png741.19 KBemma.maria

Comments

emma.maria’s picture

emma.maria
she/her
commented
Title: The email address field title moves up next to password fields at 768px to 1010 px - Firefox. only » The email address field title moves up next to password fields at 768px to 1010 px - Firefox only
DickJohnson’s picture

DickJohnson commented
Assigned: Unassigned » DickJohnson
StatusFileSize
new email-fields-reqstar-moves-up-2392487-2.patch395 bytes

It seems that there's unnecessary float: left in middle of .install-configuration-form and this is causing FF:s different kind of look. Checked on Safari, Chrome and Firefox that this doesn't break anything.

DickJohnson’s picture

DickJohnson commented
Assigned: DickJohnson » Unassigned
Status: Active » Needs review
emma.maria’s picture

emma.maria
she/her
commented
Issue tags: +Needs screenshots
emma.maria’s picture

emma.maria
she/her
commented
StatusFileSize
new FF_33_Mac_768px.png418.81 KB
new FF_33_Windows_768px.png213.74 KB
new Chrome_39_Mac_768px.png406.38 KB
new Chrome_39_Windows.png313.66 KB
new ie9_768px.png180.51 KB
new FF_33_Mac_1010px.png379.79 KB
new FF_33_Windows_1010px.png454.9 KB

I tested the patch and the fix works great! It has fixed the problem between 768px and 1010px.

Below are screenshots of Firefox on OS X and Windows at both 768px and 1010px.

Firefox 33 - OS X


Firefox 33 - Windows


I also tested other browsers to see if they were affected. Everything looks good.

Chrome 39 on OS X

Chrome 39 on Windows

IE9

Can someone else take a look at this and please set this to RTBC pretty please? Thanks :)

emma.maria’s picture

emma.maria
she/her
commented
Issue tags: -Needs screenshots
lewisnyman’s picture

lewisnyman
he/him
commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2014-12-17 at 15.23.34.jpg393.97 KB
new Screen Shot 2014-12-17 at 15.25.20.jpg470.9 KB

I tested this patch as well and it seems to of fixed the problem for me, I also tested for the problem on RTL and it no longer exists.

I also added the beta evaluation stuff.

lewisnyman’s picture

lewisnyman
he/him
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

  • webchick committed 0777508 on 8.0.x 
    Issue #2392487 by emma.maria, LewisNyman, DickJohnson: The email address...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Wow, great work finding, fixing, and testing this. :) It's just a bug fix so should be good to go as far as https://www.drupal.org/contribute/core/beta-changes goes.

Committed and pushed to 8.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.