Hey there,

first of all: THANK YOU! for this module. It is really great and exactly what a lot of people wanted to have since the entityreference can not process multiple entity types in one field.

I tried to use your module and a found a major bug causing it to not work correctly if you are using for example taxonomy terms. Taxonomy terms are using the "name" property as "label" other than nodes which are using "title".

Because of that the ajax request for getting taxonomy term entities silently fails. I do not know why it "silently" fails, but that does not matter at the moment.

I created a patch to fix this behavior. It will be attached in the first comment.

Please review and merge it ASAP, because your module is not usable else.

Greetings
func0der

CommentFileSizeAuthor
#1 entity_reference_multiple-fix_entity_sorting-2391735-1.patch611 bytesfunc0der

Comments

func0der’s picture

func0der commented
Status: Active » Needs review
StatusFileSize
new entity_reference_multiple-fix_entity_sorting-2391735-1.patch611 bytes

There you go.

func0der’s picture

func0der commented
Title: Ordering of entities does not work for entites without "title" property as "label". » [PATCH] Ordering of entities does not work for entites without "title" property as "label".

  • func0der authored 41c13ab on 7.x-2.x 
    issue #2391735: [PATCH] Ordering of entities does not work for entites...
zestagio’s picture

zestagio commented

Hi, Thanks for you patch. Patch was applied

zestagio’s picture

zestagio commented
Status: Needs review » Closed (fixed)