Problem/Motivation

Proposed resolution

Methods like EntityTypeInterface::set() should use @return $this instead of @return static to support better static type checking/autocompletion support

Remaining tasks

User interface changes

API changes

Original report by @username

CommentFileSizeAuthor
#2 drupal8-EntityInterface-2391295-1.patch2.13 KBpushpinderchauhan

Comments

dawehner’s picture

dawehner
Primary language German
commented
Issue summary: View changes
Issue tags: +Novice
pushpinderchauhan’s picture

pushpinderchauhan commented
Status: Active » Needs review
StatusFileSize
new drupal8-EntityInterface-2391295-1.patch2.13 KB

trying first.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Love it!!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Very nice, thanks! @return static was incorrect indeed.

This is an allowed Beta change (API docs bug fix). Committed to 8.0.x.

  • jhodgdon committed 56b8cbb on 8.0.x 
    Issue #2391295 by er.pushpinderrana, dawehner: Use @return $this instead...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.