Problem/Motivation

How many times do I have to roll this patch? :P

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because there is a small spelling error and inconsistency in the UI. (Config sync first says "synchronising" and then "synchronizing".)
Issue priority Minor because it's really a very small typo.
Unfrozen changes Unfrozen because it only changes code comments and one UI string.
Disruption Not really.

Proposed resolution

Spell it the American way as per our content guidelines.

Remaining tasks

@alexpott should add a git commit hook that checks his patches for "synchronis".

 

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Update the patch to incorporate feedback from reviews in #3 and #4 Novice Instructions
Review patch to ensure that it fixes the issue (i.e. all instances of "synchronis*" outside the vendor directory), stays within scope, is properly documented, and follows coding standards Yes Instructions

User interface changes

One string changes while configuration is being imported.

API changes

None.

CommentFileSizeAuthor
#8 interdiff.txt654 bytesxjm
#6 drupal-serialis-2388925-6.patch6.96 KBpreshetin
sssszzzz.patch6.55 KBxjm

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
znerol’s picture

znerol commented

ConfigSync.php contains serialising, should be fixed also.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
Status: Needs review » Needs work

Thanks @znerol. I've confirmed that that is the only instance for "serialising":

[mandelbrot:drupal | Wed 14:20:40] $ grep -ri "finalis" * | grep -v vendor
[mandelbrot:drupal | Wed 14:22:58] $ grep -ri "serialis" * | grep -v vendor
core/modules/config/src/Form/ConfigSync.php:   * This function is a static function to avoid serialising the ConfigSync

Makes sense to add that to this patch as well. Adding a novice task to update the patch.

preshetin’s picture

preshetin commented
Assigned: Unassigned » preshetin
preshetin’s picture

preshetin commented
Status: Needs work » Needs review
StatusFileSize
new drupal-serialis-2388925-6.patch6.96 KB
eidoscom’s picture

eidoscom
Primary language Catalan
commented
Status: Needs review » Reviewed & tested by the community

It seems that all is ok now :)

xjm’s picture

xjm
she/her
Primary language English
commented
StatusFileSize
new interdiff.txt654 bytes

Thanks @preshetin and @eidoscom! Here is an interdiff between the initial patch and #6. (It's always helpful to provide an interdiff when updating an existing patch.)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a198ce6 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.

  • alexpott committed a198ce6 on 8.0.x 
    Issue #2388925 by xjm, preshetin: British again invade config sync
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

btw. the British have not invaded config sync - they live in config sync - they just forgot to defer favourite English teachers.

[Editted for colourful use of language]

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.