Problem/Motivation
The UserAccessControllHandler::checkFieldAccess() method has a $explicit_check_fields array. This is meant to be used to blacklist fields, like password from the general admin permission. However, This is currently:
$explicit_check_fields = array(
'password',
);
Oops, we don't have a field called 'password', but we do have one called 'pass'.
Proposed resolution
Change this to the correct 'pass' field name, and amend UserAccessControlHandlerTest to reflect this.
Get confirmation this IS a bug and that current tests are just playing into the hands of this bug, with the values modified to make the tests pass...?
Remaining tasks
Review of above
User interface changes
N/A
API changes
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| d8.user-pass-field-access.patch | 1.27 KB | damiankloip |
Comments
Comment #1
berdirYes, confirmed, definitely wrong.
Tests were wrong, we can't have tests for our tests, so I don't think there's something left to do here?
Comment #2
damiankloip commentedIndeed, if we start testing our tests then we will never get D8 out of the door :)
Comment #3
alexpottCommitted 5b06c5b and pushed to 8.0.x. Thanks!