Tests for Drag and drop

This broke all of tabledrag. I checked menu UI and block UI as well.

It was just the result of a sloppy change in the other issue.

I manually tested, everything works now.

It is a duplicate of #2387523: Tabledrag broken after JS setting separate asset type

This one was tested and RTBC'd.

Committers, please also credit @freblasty

+++ b/core/includes/common.inc
@@ -2159,7 +2159,7 @@ function drupal_attach_tabledrag(&$element, array $options) {
-  $element['#attached']['drupalSettings'][$options['table_id']][$group][$tabledrag_id] = array(
+  $element['#attached']['drupalSettings']['tableDrag'][$options['table_id']][$group][$tabledrag_id] = array(

This is a php code change. Can we add tests for this?

According to Tim, this wouldn't give us something we could check in the markup, only in the JS settings. So presumably this needs Behat or similar to actually test meaningfully.

So for now, let's kill the regression. Committed and pushed #3 to 8.0.x. Thanks!

Leaving open/postponed for the tests for when it's possible. Ideally, this would go into some queue somewhere for "front-end stuff we really need to test when we get front-end testing."

I agree with #8, but in case someone *really* wants to just test the PHP part of this, and assert random keys in a giant array, we could.

Why can't we just create a simple method just like Drupal\system\Tests\Theme\TableTest::testThemeTableStickyHeaders()? Or a test same as PathElementFormTest for core/lib/Drupal/Core/Render/Element/Table.php. In which we create table elements in a form (TableFormTest::buildForm()) and then do some asserts on $form = \Drupal::get('form_builder')->getForm(\Drupal\system\Tests\Element\TableFormTest());

jibran

This change help me, thanks!!!

Behat is not for 8.0.x really.

Javascript test coverage might be, moving back for now.

Although this is a task.

I can't see why this is postponed, it has two commits on it.