The shortcut module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.
See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.
| Issue category | Task, because this is a coding standards change. |
|---|---|
| Issue priority | Not critical because coding standard changes are not critical. |
| Unfrozen changes | Unfrozen because it only changes automated tests. |
| Disruption | There is no disruption expected from this sort of change. |
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | clean_up_shortcut-2388009-3.patch | 7.48 KB | hussainweb |
| #3 | interdiff-1-3.txt | 831 bytes | hussainweb |
| #1 | clean_up_shortcut-2388009-1.patch | 7.47 KB | hussainweb |
Comments
Comment #1
hussainwebSkipping root_user in ShortcutLinksTest as that comes from WebTestBase in simpletest.
Comment #3
hussainwebAnother typo. :( I hope this works.
Comment #4
mile23The patch in #3 refactors class-level properties from under_score to camelCase as the coding standards demand.
I know this because I applied the patch, ran my own coding standards review with netbeansdrupalcomposed, and poked through all the test classes to find camel case and underscore violations.
Most importantly, the patch refactors properties of
Drupal\shortcut\Tests\ShortcutTestBaseand adds relevant@varannotation.Comment #5
mile23Ugh. I meant to set this to RTBC in #4.
Comment #6
alexpottCommitted 5ed1ed8 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation for to the issue summary.