The toolbar module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.

See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because this is a coding standards change.
Issue priority Not critical because coding standard changes are not critical.
Unfrozen changes Unfrozen because it only changes automated tests.
Disruption There is no disruption expected from this sort of change.
CommentFileSizeAuthor
#4 clean_up_toolbar_module-2387973-4.patch15.75 KBtibbsa
#4 clean_up_toolbar_module-2387973-1-4-interdiff.txt9.08 KBtibbsa
#1 clean_up_toolbar_module-2387973-1.patch9.51 KBhussainweb

Comments

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new clean_up_toolbar_module-2387973-1.patch9.51 KB
tibbsa’s picture

tibbsa commented
Status: Needs review » Reviewed & tested by the community

The patch in #1 appears correct. I did not find any other instances of class properties incorrectly named, and verified that there are no class properties referenced that are undeclared.

This still applies cleanly to HEAD.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Comments need updating too. For example:

// Store the admin_user admin menu subtrees hash for comparison later.

in ToolbarAdminMenuTest

tibbsa’s picture

tibbsa commented
Status: Needs work » Needs review
StatusFileSize
new clean_up_toolbar_module-2387973-1-4-interdiff.txt9.08 KB
new clean_up_toolbar_module-2387973-4.patch15.75 KB
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Reviewed & tested by the community

Patch applies, tests are green, and I couldn't find any extra underscore property references in the doc lines.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1d29fd0 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.

  • alexpott committed 1d29fd0 on 8.0.x 
    Issue #2387973 by tibbsa, hussainweb: Clean-up toolbar module test...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.