This annoys me every time I browse through EntityStorageInterface, the camel casing is incorrect for what should be getQueryServiceName.

PHP doesn't care about upper/lower casing in interface method names, so this should have no impact other than visual.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dixon_’s picture

Issue summary: View changes
skwashd’s picture

Status: Needs review » Reviewed & tested by the community

The additional cases of carpal tunnel syndrome due to the increased use of shift as a result of this patch will be offset by the consistency.

skwashd’s picture

Status: Reviewed & tested by the community » Needs work

I should have grep'd before marking this as RTBC.

The following method names and calls need to be updated too:

core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:337:   * Implements Drupal\Core\Entity\EntityStorageInterface::getQueryServicename().
core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:339:  public function getQueryServicename() {
core/lib/Drupal/Core/Entity/EntityStorageInterface.php:169:   * @see \Drupal\Core\Entity\EntityStorageInterface::getQueryServicename()
core/lib/Drupal/Core/Entity/KeyValueStore/KeyValueEntityStorage.php:205:  public function getQueryServicename() {
core/lib/Drupal/Core/Entity/Query/QueryFactory.php:51:    $service_name = $this->entityManager->getStorage($entity_type_id)->getQueryServicename();
core/lib/Drupal/Core/Entity/Query/QueryFactory.php:68:    $service_name = $this->entityManager->getStorage($entity_type_id)->getQueryServicename();
dixon_’s picture

Status: Needs work » Needs review
FileSize
3.48 KB

@skwashd Good catch!

skwashd’s picture

Status: Needs review » Reviewed & tested by the community

Now it is clicking the RTBC button that is giving me RSI.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue is a minor bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed d612558 and pushed to 8.0.x. Thanks!

  • alexpott committed d612558 on 8.0.x
    Issue #2387781 by dixon_: Fix camel case for method in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.