Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This annoys me every time I browse through EntityStorageInterface
, the camel casing is incorrect for what should be getQueryServiceName
.
PHP doesn't care about upper/lower casing in interface method names, so this should have no impact other than visual.
Comment | File | Size | Author |
---|---|---|---|
#4 | getqueryservicename-camel-case-4.patch | 3.48 KB | dixon_ |
getqueryservicename-camel-case.patch | 576 bytes | dixon_ | |
Comments
Comment #1
dixon_Comment #2
skwashd CreditAttribution: skwashd commentedThe additional cases of carpal tunnel syndrome due to the increased use of shift as a result of this patch will be offset by the consistency.
Comment #3
skwashd CreditAttribution: skwashd commentedI should have grep'd before marking this as RTBC.
The following method names and calls need to be updated too:
Comment #4
dixon_@skwashd Good catch!
Comment #5
skwashd CreditAttribution: skwashd commentedNow it is clicking the RTBC button that is giving me RSI.
Comment #6
alexpottThis issue is a minor bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed d612558 and pushed to 8.0.x. Thanks!