ConfigInstallWebTest is broken

1. +++ b/core/modules/config/src/Tests/ConfigInstallWebTest.php
   @@ -132,7 +132,8 @@ function testInstallProfileConfigOverwrite() {
        // Turn on the test module, which will attempt to replace the
        // configuration data. This attempt to replace the active configuration
        // should be ignored.
   

   This comment doesn't match the code, the test module referred to is empty. This fails because the config_existing_default_config_test.yml is wrongly named, should be config_existing_default_config_test.info.yml. I don't know if this is intentional or not. CMI folks may want to take a look at this.

2. +++ b/core/modules/config/src/Tests/ConfigInstallWebTest.php
   @@ -132,7 +132,8 @@ function testInstallProfileConfigOverwrite() {
   -    \Drupal::service('module_installer')->install(array('config_existing_default_config_test'));
   +    $status = \Drupal::service('module_installer')->install(array('config_existing_default_config_test'));
   +    $this->assertTrue($status, "The module config_existing_default_config_test was installed.");
   

   Another test in the class (::testIntegrationModuleReinstallation) also does similar ModuleInstaller::install(), maybe we can extend this check to include those.

1. That is wrong, it should be renamed. Tagging Novice to do exactly that, provide a patch with that rename and the test change from the initial patch and then it should be green.

Is this the file that should be renamed?

I can't say, the patch doesn't contain it :)

Trying...

Rename looks correct, have a look at https://www.drupal.org/documentation/git/configure for configuring git diff so that it picks up the rename as a rename and not a delete/add of a new file.

I believe we no longer add explicit hidden: true to modules in tests/modules folders, as they are automatically hidden (or non-existent, actually) when you're not within a test.

Config git successfully ! Thank you :)

I think this is good to go, we could also check the other install() call, but I think #1719648: ModuleInstaller::install() should provide more information than simply returning FALSE when a module isn't in the file system will take care of that in a more generic and better way.

RTBC, alexpott will probably want to see this, so assigning to him.

Nice find. Committed 8e7f24f and pushed to 8.0.x. Thanks!