In building the subject line, the MessageNotifierEmail class strips tags from the text but it fails to decode HTML entities. So a subject line which should be 'New post on the topic "some title"' actually comes out as 'New post on the topic "some title"'.

Fortunately this is a simple fix. Patch attached.

Comments

alfaguru’s picture

Issue summary: View changes
StatusFileSize
new753 bytes
Andy_D’s picture

I've also seen this error and have additional line feed's showing up (=0A) so I added a simple trim to ensure "good string" before we start striping and encoding. Patch enclosed.

rosk0’s picture

Title: HTML entities in subject » HTML entities in email subject
Version: 7.x-2.5 » 7.x-2.x-dev
Status: Active » Needs review

PR with fix for current issue https://github.com/Gizra/message_notify/pull/6.

rosk0’s picture

StatusFileSize
new1.86 KB

Patch from the specified PR.

rosk0’s picture

Issue summary: View changes

Fixed issue description.

strangeways’s picture

I was going to suggest changing html_decode_entity() to Drupal's decode_entities(), but it looks like the PR on GitHub already has that change. So I'm just attaching the updated patch from there.

brunodbo’s picture

Patch in #6 fixes this issue for me. Thanks!

angel.h’s picture

Status: Needs review » Reviewed & tested by the community

This looks ready to be committed.

bluegeek9’s picture

Status: Reviewed & tested by the community » Closed (outdated)