In building the subject line, the MessageNotifierEmail class strips tags from the text but it fails to decode HTML entities. So a subject line which should be 'New post on the topic "some title"' actually comes out as 'New post on the topic "some title"'.
Fortunately this is a simple fix. Patch attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | message_notify-decode_entities-2386273-6.patch | 1.85 KB | strangeways |
| #4 | message_notify-html_entities_decode-2386273-4.patch | 1.86 KB | rosk0 |
Comments
Comment #1
alfaguru commentedComment #2
Andy_D commentedI've also seen this error and have additional line feed's showing up (=0A) so I added a simple trim to ensure "good string" before we start striping and encoding. Patch enclosed.
Comment #3
rosk0PR with fix for current issue https://github.com/Gizra/message_notify/pull/6.
Comment #4
rosk0Patch from the specified PR.
Comment #5
rosk0Fixed issue description.
Comment #6
strangeways commentedI was going to suggest changing html_decode_entity() to Drupal's decode_entities(), but it looks like the PR on GitHub already has that change. So I'm just attaching the updated patch from there.
Comment #7
brunodboPatch in #6 fixes this issue for me. Thanks!
Comment #8
angel.hThis looks ready to be committed.
Comment #9
bluegeek9 commented