Since updating to 7.x-3.4 (I'm pretty sure it wasn't doing this before) on 403 pages I now get a javascript alert popup saying "Colorbox Library is not loaded".

Comments

paulaz’s picture

Hello, I have the same problem, and I have not made this system where I am working, so I don't know what the problem is.
Thank you for your help.

The Webmaster Centre Ltd’s picture

I think that this might be related to this fix: https://www.drupal.org/node/2218161

The Webmaster Centre Ltd’s picture

Yes it is. Reverting back to the previous version (i.e., without the changes detailed here: http://cgit.drupalcode.org/colorbox_node/commit/?id=66e7875) solves the problem.

criscom’s picture

Priority: Normal » Major

Thanks Webmaster. Downgrading colorbox_node to version 7.x-3.3 resolved the issue. As of now version 7.x-3.4 cannot be used on production sites. Please fix.

aaronbauman’s picture

Version: 7.x-3.4 » 7.x-3.x-dev
Component: Code » User interface
Status: Active » Needs review
StatusFileSize
new468 bytes

Here's a patch against latest dev.

aaronbauman’s picture

If this alert message is more than just debugging cruft, then I think:
1) It should not appear by default.
2) It should be configurable from within colorbox node settings to turn it on and off.

iLLin’s picture

Yea I wasn't a fan of putting it in there. Once I get more time I will clean up this issue queue and put out a new release.

somatics’s picture

We have what I think is the same problem — but the alert was displaying on many pages not just 403 -- which we originally posted at https://www.drupal.org/node/2405649

So far, our solution was to disable the Colorbox Node module; it was failing to show the content within the colorbox anyway since the library wasn’t loading. Any idea when this will be fixed — meaning the library will successfully load, not just start silencing the error that it isn’t loading?

iLLin’s picture

If colorbox is not loading, then you need to find out why. You need to troubleshoot the colorbox module, not this one. I just extend that module.

aaronbauman’s picture

iLLin, that may be true, but colorbox node is the module which is sending the blocking, user-facing error.
This kind of error is not appropriate to show end-users, regardless of whatever dependencies are failing.
The patch is one line that gets rid of the notice altogether.

iLLin’s picture

Oh yea, that's fine and this will be removed in the next version. I never like this anyway, I may just change it to console.log (but also check to make sure that function exists so IE doesn't break). I just haven't had time. Just comment the line out until I get a new version out.

somatics’s picture

iLLin,

The reason I chimed in on this thread (or searched for it in the first place) is because the Colorbox contributor indicated it was a problem with the Colorbox Node module:

https://www.drupal.org/node/2405649#comment-9606859

iLLin’s picture

OK OK, :). I am not arguing to keep it in, I have been convinced! I just haven't had time to sit down and get some of these fixes in.

  • iLLin committed cae38d4 on 7.x-3.x authored by aaronbauman
    Issue #2385431 by aaronbauman: Throws javascript "Colorbox Library is...
iLLin’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.