The entity_reference module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.

See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because this is a coding standards change.
Issue priority Not critical because coding standard changes are not critical.
Unfrozen changes Unfrozen because it only changes automated tests.
Disruption There is no disruption expected from this sort of change.
CommentFileSizeAuthor
#1 entity_reference-testing-camelcase-2385227-1.patch5.03 KBtibbsa

Comments

tibbsa’s picture

tibbsa commented
Status: Active » Needs review
StatusFileSize
new entity_reference-testing-camelcase-2385227-1.patch5.03 KB
tibbsa’s picture

tibbsa commented
Assigned: tibbsa » Unassigned
amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 4fe5455 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.

  • alexpott committed 4fe5455 on 8.0.x 
    Issue #2385227 by tibbsa: Clean-up entity_reference module test members...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.