The editor module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.

See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because this is a coding standards change.
Issue priority Not critical because coding standard changes are not critical.
Unfrozen changes Unfrozen because it only changes automated tests.
Disruption There is no disruption expected from this sort of change.
CommentFileSizeAuthor
#4 editor-testing-camelcase-2385225-interdiff-1-4.txt1.04 KBtibbsa
#4 editor-testing-camelcase-2385225-4.patch19.56 KBtibbsa
#1 editor-testing-camelcase-2385225-1.patch19.39 KBtibbsa
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tibbsa’s picture

tibbsa CreditAttribution: tibbsa commented
Status: Active » Needs review
FileSize
editor-testing-camelcase-2385225-1.patch19.39 KB
tibbsa’s picture

tibbsa CreditAttribution: tibbsa commented
Assigned: tibbsa » Unassigned
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs review » Needs work 
  1. +++ b/core/modules/editor/src/Tests/EditorLoadingTest.php
@@ -52,9 +73,9 @@ protected function setUp() {
     //   - "untrusted": plain_text
     //   - "normal": plain_text, filtered_html
     //   - "privileged": plain_text, filtered_html, full_html

    Please remove these comments, since their contents are now captured by the class-level docs that you added. 

  2. +++ b/core/modules/editor/src/Tests/EditorLoadingTest.php
@@ -71,19 +92,19 @@ public function testLoading() {
-    // The normal user:
+    // The privileged user:

    Good catch :)

tibbsa’s picture

tibbsa CreditAttribution: tibbsa commented
Status: Needs work » Needs review
FileSize
editor-testing-camelcase-2385225-4.patch19.56 KB
editor-testing-camelcase-2385225-interdiff-1-4.txt1.04 KB

Status: Needs review » Needs work

The last submitted patch, 4: editor-testing-camelcase-2385225-4.patch, failed testing.

tibbsa queued 4: editor-testing-camelcase-2385225-4.patch for re-testing.

areke’s picture

areke CreditAttribution: areke commented
Status: Needs work » Needs review
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented
Status: Needs review » Reviewed & tested by the community

Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed b644bff and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.

  • alexpott committed b644bff on 8.0.x 
    Issue #2385225 by tibbsa: Clean-up editor module test members - ensure...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.