The dblog module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.

See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because this is a coding standards change.
Issue priority Not critical because coding standard changes are not critical.
Unfrozen changes Unfrozen because it only changes automated tests.
Disruption There is no disruption expected from this sort of change.
CommentFileSizeAuthor
#1 dblog-testing-camelcase-2384689-1.patch4.55 KBtibbsa

Comments

tibbsa’s picture

tibbsa commented
StatusFileSize
new dblog-testing-camelcase-2384689-1.patch4.55 KB

Rationale: The rename of $big_user to $adminUser and $any_user to $webUser arises from the comment at #1811638-6: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention about 'political correctness'. This is consistent with the other tests as well.

tibbsa’s picture

tibbsa commented
Assigned: tibbsa » Unassigned
areke’s picture

areke commented
Status: Needs review » Reviewed & tested by the community

This looks good. A quick grep shows that all the needed changes were made.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 08e8a6d and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.

  • alexpott committed 08e8a6d on 8.0.x 
    Issue #2384689 by tibbsa: Clean-up dblog module test members - ensure...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.