The dblog module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.
See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.
| Issue category | Task, because this is a coding standards change. |
|---|---|
| Issue priority | Not critical because coding standard changes are not critical. |
| Unfrozen changes | Unfrozen because it only changes automated tests. |
| Disruption | There is no disruption expected from this sort of change. |
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | dblog-testing-camelcase-2384689-1.patch | 4.55 KB | tibbsa |
Comments
Comment #1
tibbsa commentedRationale: The rename of $big_user to $adminUser and $any_user to $webUser arises from the comment at #1811638-6: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention about 'political correctness'. This is consistent with the other tests as well.
Comment #2
tibbsa commentedComment #3
areke commentedThis looks good. A quick grep shows that all the needed changes were made.
Comment #4
alexpottCommitted 08e8a6d and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation for to the issue summary.