Make the class variables protected for Action

I would like to get this fixed. So I will do a good review for posted patches.

The class variables $id and $label need to become protected.
You can use the functions id() as a getter function for the $id variable and label() as a getter function for the variable $label.

The action entity is defined in the system module.

+++ b/core/modules/system/src/Entity/Action.php
@@ -87,6 +87,36 @@ protected function getPluginCollection() {
+  public function label() {
+    return $this->get('label');
+  }
...
+  public function id() {
+    return $this->get('id');
+  }

These functions are inherited from the Entity class. So they can be removed.

+++ b/core/modules/system/src/Entity/Action.php
@@ -87,6 +87,36 @@ protected function getPluginCollection() {
+  public function setLabel($label) {
+    $this->set('label', $label);
+    return $this;
+  }
...
+  public function setId($id) {
+    $this->set('id', $id);
+    return $this;
+  }

These functions are not used. You can remove them and use set('id', $value) and set('label', $value).

@areke: Something went wrong with creating your last patch. :(

All the class variables are protected.
There are already getter functions available, so no need for new ones.
The test-server give it green.
It all looks good to me, so for me it is RTBC.

@craigsilk: The getter function for the variable $id is id() and the getter for the variable $label is label(). If you want to set the variable $id or $label you must use the set() function.