Make the class variables protected for ImageStyle

I would like to get this fixed. So I will do a good review for posted patches.

The class variables $name and $label need to become protected.
You can use the functions id() as a getter function for the name variable and label() as a getter function for the variable label.

+++ b/core/modules/image/src/Entity/ImageStyle.php
@@ -392,6 +392,21 @@ public function setName($name) {
+   * {@inheritdoc}
+   */
+  public function getLabel() {
+    return $this->get('label');
+  }
+
+  /**
+   * {@inheritdoc}
+   */
+  public function setLabel($label) {
+    $this->set('label', $label);
+    return $this;
+  }

The function getLabel() is not necessary. There is a build in function label().
The function setLabel() will probably not be used. Maybe only in testing. You can remove them and use set('label', $value).

The reason that your patch failed testing is that outside the NodeType class the class variables are no longer accessible. And it will result in an error. Use the methods id() and label() to fix this. If you need the set a variable use set('name', $value) or set('label', $value).

+++ b/core/modules/image/src/Entity/ImageStyle.php
@@ -99,6 +99,22 @@ public function id() {
+  public function label() {
+    return $this->get('label');
+  }

This function is inherited from the Entity class. So it can be removed.

+++ b/core/modules/image/src/Entity/ImageStyle.php
@@ -99,6 +99,22 @@ public function id() {
+  public function setLabel($label) {
+    $this->set('label', $label);
+    return $this;
+  }

This function is not used. You can remove it and use set('label', $value).

+++ b/core/modules/image/src/Tests/ImageAdminStylesTest.php
@@ -246,7 +246,7 @@ function testStyle() {
-        '%style' => $style->label,
+        '%style' => $style->get('label'),

Your solution also works, but there is a build in function label() that does the same. And that is the function that other developers expect.

All the class variables are protected.
There are already getter functions available, so no need for new ones.
The test-server give it green.
It all looks good to me, so for me it is RTBC.