The contextual module uses test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.

See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because this is a coding standards change.
Issue priority Not critical because coding standard changes are not critical.
Unfrozen changes Unfrozen because it only changes automated tests.
Disruption There is no disruption expected from this sort of change.

Comments

tibbsa’s picture

Status: Active » Needs review
StatusFileSize
new2.89 KB
tibbsa’s picture

Assigned: tibbsa » Unassigned
wim leers’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +php-novice, +Quickfix
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Since this change is isolated to one particular test, the disruption is moot, so this seems good to go.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 6ec9c1f on 8.0.x
    Issue #2384165 by tibbsa: Clean-up Contextual module test members —...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.