Problem/Motivation

In #2381973-56: View wizard creates 'invalid' views out of the box, missing plugin_ids, insecure permissions @alexpott found that pathField and pathFieldsSupplemental are not used anywhere (outside of their getters) in views wizards. This looks like genuine dead code. Possibly a start of something that was not implemented fully.

Proposed resolution

Remove unless they are useful for something.

Remaining tasks

Review. Commit.

User interface changes

None.

API changes

Unused public methods removed.

CommentFileSizeAuthor
#1 2383667-remove-path-field.patch6.56 KBGábor Hojtsy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Title: pathField pathFieldSupplemental is not used in Views wizards » pathField and pathFieldsSupplemental is not used in Views wizards
Issue summary: View changes
FileSize
2383667-remove-path-field.patch6.56 KB
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Good catch!

All that code just exists for the jump_menu functionality which was provided by ctools.
Due to the removal of the ctools dependency, we can drop all that $pathFieldstuff at the same time.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 34c1da0 and pushed to 8.0.x. Thanks!

  • alexpott committed 34c1da0 on 8.0.x 
    Issue #2383667 by Gábor Hojtsy: pathField and pathFieldsSupplemental is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.