The contact module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.
See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.
Beta phase evaluation
| Issue category | Task, because this is a coding standards change. |
|---|---|
| Issue priority | Not critical because coding standard changes are not critical. |
| Unfrozen changes | Unfrozen because it only changes automated tests. |
| Disruption | There is no disruption expected from this sort of change. |
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | contact_cleanup-2383573-1.patch | 13.61 KB | tibbsa |
Comments
Comment #1
tibbsa commentedComment #2
tibbsa commentedComment #3
pacproduct commentedThanks @tibbsa.
Reviewed the patch in #1.
Still applies to current HEAD and changes look okay.
Comment #4
alexpottCommitted 60950f3 and pushed to 8.0.x. Thanks!
Thanks for adding the beta evaluation for to the issue summary.