The contact module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be renamed to bigUser, webUser and adminUser. In addition, some properties are undefined but should be.

See the parent issue #1811638: [meta] Clean-up Test members - ensure property definition and use of camelCase naming convention.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task, because this is a coding standards change.
Issue priority Not critical because coding standard changes are not critical.
Unfrozen changes Unfrozen because it only changes automated tests.
Disruption There is no disruption expected from this sort of change.
CommentFileSizeAuthor
#1 contact_cleanup-2383573-1.patch13.61 KBtibbsa
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tibbsa’s picture

tibbsa CreditAttribution: tibbsa commented
Status: Active » Needs review
FileSize
contact_cleanup-2383573-1.patch13.61 KB
tibbsa’s picture

tibbsa CreditAttribution: tibbsa commented
Assigned: tibbsa » Unassigned
pacproduct’s picture

pacproduct CreditAttribution: pacproduct commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +CapgeminiDrupalDay2014

Thanks @tibbsa.
Reviewed the patch in #1.
Still applies to current HEAD and changes look okay.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 60950f3 and pushed to 8.0.x. Thanks!

Thanks for adding the beta evaluation for to the issue summary.

  • alexpott committed 60950f3 on 8.0.x 
    Issue #2383573 by tibbsa: Clean-up Contact module Test members - ensure...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.