Improve documentation for module_exists().

CommentFileSizeAuthor
#4 core-2382801-module_exits_docs-4.patch595 bytespushpinderchauhan
#4 interdiff-2382801-1-4.txt445 bytespushpinderchauhan
#1 core-2382801-module_exits_docs-1.patch598 bytesliam morland

Comments

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new core-2382801-module_exits_docs-1.patch598 bytes
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Looks great, except:

 * @return boolean

In @param/@return we use "bool" not "boolean".

pushpinderchauhan’s picture

pushpinderchauhan commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2382801-1-4.txt445 bytes
new core-2382801-module_exits_docs-4.patch595 bytes

Incorporated #3 changes.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

Thanks, looks good now! Committed to 7.x.

  • jhodgdon committed a6c50f0 on 7.x 
    Issue #2382801 by er.pushpinderrana, Liam Morland: Improve documentation...
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Thanks very much!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.