Thanks to issues including
#2350943: [Meta] Untangle Drupal 8 page rendering
#2184907: Remove uses of drupal_add_http_header and related functions
#2073823: [META] Remove drupal_add_js() calls
#2073819: [META] Remove direct calls to drupal_add_css()

the following functions are no longer available for general use, to be removed in #2477223: Refactor _drupal_add_html_head, drupal_get_html_head, _drupal_add_html_head_link into the attachments processor, remove from common.inc.
_drupal_add_html_head()
drupal_get_html_head
_drupal_add_html_head_link()

They are still marked deprecated, but that's not really accurate. As far as third party code is concerned they should be considered removed.

drupal_process_attached() does still exist and is still a public API, but the documentation is incorrect. Specifically, it doesn't mention the types handled in the final foreach of the function, and it suggests that you can call arbitrary functions which is incorrect.

Remaining tasks

Comments

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Issue summary: View changes
Related issues: +#2382873: [policy] Formalize coding standard for functions not intended for public use
rickvug’s picture

rickvug commented

I scanned common.inc to gauge where functions related to JS/CSS attachment were at. See the status below. Beyond what is already marked as deprecated I see that there are additional functions and constants that are also prime candidates for refactoring and removal. While updating documentation to be accurate is useful, I wonder if a full plan to complete the refactoring is warranted. There was some great refactoring of drupal_render recently (#2346937: Implement a Renderer service; reduces drupal_render / _theme service container calls) as well as a lot of work on streamlining page rendering. This work might fit right in and help complete the picture while also providing improved consistency.

Deprecated:

  • _drupal_add_js - @deprecated as of Drupal 8.0. Use the #attached key in render arrays instead.
  • _drupal_add_css() - @deprecated as of Drupal 8.0. Use the #attached key in render arrays instead.
  • _drupal_add_html_head - @deprecated in Drupal 8.0.x, will be removed before Drupal 8.0.0. Use #attached on render arrays.
  • drupal_get_html_head - @deprecated in Drupal 8.0.x, will be removed before Drupal 8.0.0. Use #attached on render arrays.
  • _drupal_add_html_head_link - @deprecated in Drupal 8.0.x, will be removed before Drupal 8.0.0. Use #attached on render arrays.
  • drupal_clear_css_cache - @deprecated in Drupal 8.x, will be removed before Drupal 9.0. Use \Drupal\Core\Asset\AssetCollectionOptimizerInterface::deleteAll().
  • drupal_clear_js_cache - @deprecated in Drupal 8.x, will be removed before Drupal 9.0. Use \Drupal\Core\Asset\AssetCollectionOptimizerInterface::deleteAll().
  • drupal_clean_css_identifier - @deprecated in Drupal 8.x-dev, will be removed before Drupal 8.0.0. Use \Drupal\Component\Utility\Html::cleanCssIdentifier()
  • drupal_html_class - @deprecated in Drupal 8.x-dev, will be removed before Drupal 8.0.0. Use \Drupal\Component\Utility\Html::getClass()
  • drupal_html_id - @deprecated in Drupal 8.x-dev, will be removed before Drupal 8.0.0. Use \Drupal\Component\Utility\Html::getUniqueId()
  • drupal_clean_id_identifier - @deprecated in Drupal 8.x-dev, will be removed before Drupal 8.0.0. Use \Drupal\Component\Utility\Html::getId()
  • _drupal_add_library - @deprecated in Drupal 8.0.x, will be removed before Drupal 8.0.0. Use #attached on render arrays.

Other related functions not marked as deprecated:

  • drupal_http_header_attributes
  • drupal_get_css
  • drupal_get_js
  • drupal_js_defaults
  • drupal_sort_css_js
  • drupal_merge_js_settings
  • drupal_merge_attached
  • drupal_process_attached
  • drupal_process_states

Related constants (prime candidates for refactoring):

  • CSS_AGGREGATE_DEFAULT
  • CSS_AGGREGATE_THEME
  • CSS_BASE
  • CSS_LAYOUT
  • CSS_COMPONENT
  • CSS_STATE
  • CSS_THEME
  • JS_SETTING
  • JS_LIBRARY
  • JS_DEFAULT
  • JS_THEME
ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
commented
Issue summary: View changes

At this stage in the release process, any additional functions that we deprecate would need to be marked "will be removed before Drupal 9".

Many of the functions you mentioned are already being dealt with in #2205673: [META] Remove all @deprecated functions marked "remove before 8.0", this issue doesn't need to worry about any functions that we're actually going to remove before 8.

Some of the functions mentioned in the issue summary don't currently start with an underscore, so we need to decide what to do with those. Is it too late to add an underscore, even if the function doesn't work, or doesn't work the same way as it did in Drupal 7?

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Related issues: +#2467759: Refactor drupal_process_attached() so it doesn't depend on drupal_add_http_header()

See: #2467759: Refactor drupal_process_attached() so it doesn't depend on drupal_add_http_header()

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes

Fixed IS - only 3 functions left that should be removed in #2477223: Refactor _drupal_add_html_head, drupal_get_html_head, _drupal_add_html_head_link into the attachments processor, remove from common.inc.

_drupal_add_html_head()
drupal_get_html_head
_drupal_add_html_head_link()

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Active » Closed (duplicate)

I'm calling this a duplicate of #2477223: Refactor _drupal_add_html_head, drupal_get_html_head, _drupal_add_html_head_link into the attachments processor, remove from common.inc. In that issue we can update documentation for drupal_process_attached() as needed.

The @deprecated _drupal_add_html_head(), drupal_get_html_head(), and _drupal_add_html_head_link() will be vanishing, and whether or not drupal_process_attached() will remain is being considered in this issue: #2552865: Deprecate drupal_process_attached() for 8.0.0 and either throw an Exception or make it work via the RenderContext