In #2339151: Conditions / context system does not allow for multiple configurable contexts, eg. language types 162.2 alexpott points out that ContextAwarePluginAssignmentTrait::addContextAssignmentElement() gets ContextDefinitions from Plugins and passes them to ContextHandler:: getMatchingContexts() but plugins return Component ContextDefinitions and the ContextHandler expects Core ContextDefinitions. This is a very subtile observation on his part and we need to solve the docs here for the IDEs.
We used to have separate ContextAwarePluginInterfaces for Core and Component. An effort was made to merge these together, but alex's observation puts me back into the "we need a split" camp. We can do this pretty minimally though, so I'll provide a patch to that effect. Tim Plunkett and I discussed this at length and are on the same page with just provided the most minimal interface extension possible specific to this problem.
Eclipse
Comment | File | Size | Author |
---|---|---|---|
#5 | interdiff.txt | 1 KB | tim.plunkett |
#5 | 2378583-context-5.patch | 7.76 KB | tim.plunkett |
#3 | interdiff.txt | 3.29 KB | tim.plunkett |
#3 | 2378583-context-3.patch | 5.39 KB | tim.plunkett |
#1 | 2378583-1.patch | 2.1 KB | EclipseGc |
Comments
Comment #1
EclipseGc CreditAttribution: EclipseGc commentedSomething like so... ish
Eclipse
Comment #3
tim.plunkettThere are a couple other places that need this swap.
Comment #5
tim.plunkettComment #6
EclipseGc CreditAttribution: EclipseGc commentedI feel comfortable RTBCing this since there's no actual logic changes introduced and this is purely documentation in nature.
Eclipse
Comment #7
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 0d72036 and pushed to 8.0.x. Thanks!