Problem/Motivation

theme/maintenance-page.cs:

.maintenance-page {
  background-color: #e0e0d8;
  background-image: -webkit-radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
  background-image: radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
  background-repeat: repeat;
  background-position: left top, 50% 50%;
  min-height: 100%;
}

/* Maintenance theming */
.install-page,
.maintenance-page {
  background: none;
}

It doesn't seem right to first declare a background and then immediately change set it to none. This results in a black page:

Proposed resolution

Remove the second .maintenance-page selector.

Remaining tasks

- Review the patch.

User interface changes

- Seven maintenance page looks good again.

API changes

CommentFileSizeAuthor
#6 wrong-rename-background.png186.8 KBsqndr
#2 interdiff.txt390 bytessqndr
#2 2377449-2.patch443 bytessqndr
#1 2377449.patch396 bytessqndr
Screen Shot 2014-11-18 at 16.25.07.png72.97 KBsqndr
Screen Shot 2014-11-18 at 16.22.45.png36.21 KBsqndr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sqndr’s picture

sqndr CreditAttribution: sqndr commented
Assigned: sqndr » Unassigned
Status: Active » Needs review
FileSize
2377449.patch396 bytes

Here's the patch.

sqndr’s picture

sqndr CreditAttribution: sqndr commented
FileSize
2377449-2.patch443 bytes
interdiff.txt390 bytes

It seems like the entire block can be removed:

/* Maintenance theming */
.install-page,
.maintenance-page {
  background: none;
}

The .maintenance-page {} contains a background color. The .install-page {} theming should not be in this file; and the install-page.css contains it's own background. So this should all be removed.

sqndr’s picture

sqndr CreditAttribution: sqndr commented
Issue summary: View changes
sqndr’s picture

sqndr CreditAttribution: sqndr commented
Issue summary: View changes
LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented

hmm this is weird, do we know which issue this regression came from?

sqndr’s picture

sqndr CreditAttribution: sqndr commented
FileSize
wrong-rename-background.png186.8 KB

It's due to a lot of renames:

maintenance-page.css version 360af27:

.maintenance-background {
  background-color: #e0e0d8;
  background-image: -webkit-radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
  background-image: radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
  background-repeat: repeat;
  background-position: left top, 50% 50%;
  min-height: 100%;
}

/* Maintenance theming */
.install-page,
.in-maintenance {
  background: none;
}

maintenance-page.css version 9d5d3b3:

.maintenance-background {
  background-color: #e0e0d8;
  background-image: -webkit-radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
  background-image: radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
  background-repeat: repeat;
  background-position: left top, 50% 50%;
  min-height: 100%;
}

/* Maintenance theming */
.install-page,
.maintenance-page { // CHANGED FROM .in-maintenance {}
  background: none;
}

maintenance-page.css version 488116d:

.maintenance-page { // CHANGED FROM .maintenance-background {}
  background-color: #e0e0d8;
  background-image: -webkit-radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
  background-image: radial-gradient(hsl(203, 2%, 90%), hsl(203, 2%, 95%));
  background-repeat: repeat;
  background-position: left top, 50% 50%;
  min-height: 100%;
}

/* Maintenance theming */
.install-page,
.maintenance-page {
  background: none;
}
LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented
Status: Needs review » Reviewed & tested by the community

Ahh renames, that visual regression tool can't come soon enough.

Thanks!

sqndr’s picture

sqndr CreditAttribution: sqndr commented

Visual regression tool: Woop Woop!

sqndr’s picture

sqndr CreditAttribution: sqndr commented

Just a question though: when will people see the maintenance page/theming from Seven? Only when Seven is enabled as the default theme, right? Or are there other cases?

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented

Install profiles can specify their own theme on install.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

Ahh renames, that visual regression tool can't come soon enough.

+1

#9: good question, I was wondering the same. #10, aren't there any other instances where this occurs? There should be, otherwise we wouldn't have a maintenance page style for Seven?

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman commented

I believe the reason we split out the styling into Seven was because of dreammarkup - #2041793: install-page.html.twig markup and CSS (bear in mind that #2169765: Redesign update.php to be more consistent with the installation process came after this)

I remember some of the comments form here: https://www.drupal.org/node/1337554#comment-7334792

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed c618fb8 and pushed to 8.0.x. Thanks!

  • alexpott committed c618fb8 on 8.0.x 
    Issue #2377449 by sqndr: Seven maintenance page theming incorrect

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.