Problem/Motivation

  1. Add a URL alias
  2. Visit the edit form
  3. Change the system path and leave the alias as it is
  4. Press Save

Expected result: The alias was updated
Actual result: An error message appears:

The alias is already in use in this language.

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 2377343-url_alias-1-FAIL.patch2.29 KBtim.plunkett
#1 2377343-url_alias-1-PASS.patch4.2 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
Issue tags: -Needs tests
StatusFileSize
new 2377343-url_alias-1-PASS.patch4.2 KB
new 2377343-url_alias-1-FAIL.patch2.29 KB

Added tests and fixed it. The problem was that when checking for existing aliases, it was trying to use the new source, not the existing one.
Also removed some redundancy between the validate and submit.

Status: Needs review » Needs work

The last submitted patch, 1: 2377343-url_alias-1-FAIL.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review

This bug was introduced in #2209145: Move all path alias SQL queries to a single storage controller, when AliasStorage::aliasExists() was added. Previously $pid was always used in the query, and that issue switched to optionally using $source, which seems like an odd but purposeful change. I'll ping @slashsrm to take a look at this.

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community

Still applies, looks good to me - cleanup is also fine.

alexpott queued 1: 2377343-url_alias-1-PASS.patch for re-testing.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue addresses a major bug and is allowed per https://www.drupal.org/core/beta-changes. Committed a77605d and pushed to 8.0.x. Thanks!

  • alexpott committed a77605d on 8.0.x 
    Issue #2377343 by tim.plunkett: Url alias system path cannot be edited...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.