Part of meta-issue #2225347: [META] Replace calls to ENTITY_TYPE_load() and ENTITY_TYPE_load_multiple() with static method calls

See the detailed explanations and examples there.

CommentFileSizeAuthor
#3 interdiff-2377115-1-3.txt985 bytesmglaman
#3 replace_all_instances-2377115-3.patch31.25 KBmglaman
#1 replace_all_instances-2377115-1.patch31.36 KBmglaman

Comments

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new replace_all_instances-2377115-1.patch31.36 KB

Patch that replaces entity_load() and entity_load_multiple() with static methods.

Status: Needs review » Needs work

The last submitted patch, 1: replace_all_instances-2377115-1.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new replace_all_instances-2377115-3.patch31.25 KB
new interdiff-2377115-1-3.txt985 bytes

Accidentally replaced an entity_create() with static load :/. Fixed patch.

dstotijn’s picture

dstotijn commented
Status: Needs review » Reviewed & tested by the community

Applied patch, grepped for occurrences of "entity_load('field_config'" and "entity_load_multiple('field_config'"; none found. Reviewed the replacements with static method calls. Looks fine to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

The meta-issue #2225347: [META] Replace calls to ENTITY_TYPE_load() and ENTITY_TYPE_load_multiple() with static method calls has the beta evaluation form. Committed 33b66b5 and pushed to 8.0.x. Thanks!

  • alexpott committed 33b66b5 on 8.0.x 
    Issue #2377115 by mglaman: Replace all instances of entity_load('...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.