Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Noticed in #2078593: In WizardPluginBase Rename Views properties to core standards by @alansaviolobo
some full namespace paths are wrong in comments, like
- * @param \Drupal\views\View\plugin\display\DisplayPluginBase $display
+ * @param \Drupal\views\Plugin\views\display\DisplayPluginBase $display
ag --literal '\plugin\display\DisplayPluginBase' core/*
shows this is only in WizardPluginBase
Beta phase evaluation
| Issue category | Bug because the documentation is wrong. |
|---|---|
| Issue priority | Minor because https://www.drupal.org/core/issue-priority mentions correction of typo in comment is minor. |
| Unfrozen changes | Unfrozen because it only changes documentation |
Proposed resolution
Fix just those wrong paths in the comments in this class.
Remaining tasks
| Task | Novice task? | Contributor instructions | Complete? |
|---|---|---|---|
| Create a patch | novice | Instructions | |
| Update the issue summary noting if allowed during the beta | Instructions | done | |
| Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | novice | Instructions |
User interface changes
No.
API changes
No.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | some_full_name_space-2376403-2.patch | 2.18 KB | Tom Verhaeghe |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedDisplayPluginBase should be referred to by:
\Drupal\views\Plugin\views\display\DisplayPluginBase
(see the contains line and the namespace line near the top of core/modules/views/src/Plugin/views/display/DisplayPluginBase.php
--
ag --literal '\plugin\display\DisplayPluginBase' core/*
core/modules/views/src/Plugin/views/wizard/WizardPluginBase.php
1161: * @param \Drupal\views\View\plugin\display\DisplayPluginBase $display
1165: * @param \Drupal\views\View\plugin\display\DisplayPluginBase $default_display
1197: * @param \Drupal\views\View\plugin\display\DisplayPluginBase $display
1201: * @param \Drupal\views\View\plugin\display\DisplayPluginBase $default_display
shows which lines need to change.
(ag: https://github.com/ggreer/the_silver_searcher )
Comment #2
Tom Verhaeghe CreditAttribution: Tom Verhaeghe commentedChanged defect classpath in comments for setDefaultOptions() and setOverrideOptions() functions.
Comment #3
dawehnerThank you, for both providing a patch and create the initial issue.
Comment #4
YesCT CreditAttribution: YesCT commentedrtbc +1
that looks great.
Comment #5
alexpottThis issue is a minor bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed 057bab1 and pushed to 8.0.x. Thanks!