CommentFileSizeAuthor
#5 2375923-test-only.patch746 bytesamateescu
#5 2375923-5.patch1.36 KBamateescu
favicon.patch645 bytesolli

Comments

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

I found the same thing today and wrote the same patch :)

This was caused by #2352155: Remove HtmlFragment/HtmlPage.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Could this use a webtest?

yesct’s picture

yesct commented
Parent issue: » #2352155: Remove HtmlFragment/HtmlPage
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

D'oh! Patch looks good. RTBC+1

amateescu’s picture

amateescu commented
StatusFileSize
new 2375923-5.patch1.36 KB
new 2375923-test-only.patch746 bytes

Could this use a webtest?

Sure thing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: 2375923-test-only.patch, failed testing.

amateescu’s picture

amateescu commented
Status: Needs work » Reviewed & tested by the community
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Awesome, wont go missing again;)

Thank you, RTBC++

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed fa140d2 on 8.0.x 
    Issue #2375923 by amateescu, olli: Fixed favicon missing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.