Problem/Motivation
Follow up of #2348007: Taxonomy term view needs status filter
In #2348007-30: Taxonomy term view needs status filter catch said
How come we're querying on current language on monolingual sites?
Proposed resolution
Don't filter by language in case the site is monolingual
Remaining tasks
Commit it.
User interface changes
None
API changes
None
Comment | File | Size | Author |
---|---|---|---|
#9 | 2375879-9.patch | 8.22 KB | jibran |
#9 | interdiff.txt | 1.51 KB | jibran |
Comments
Comment #1
dawehnerComment #2
jibranThanks @dawehner for the nice fix. Some minor issues other then this It is RTBC if green.
debug code.
This fix is for critical bug so i think it is fine.
not multilingual would be better.
Comment #4
jibranFixed the test and #2
Comment #5
vijaycs85Overall, looks good to me. +1 to RTBC. setting D8MI tags to get another review from @Gabor.
Comment #6
Gábor HojtsyI don't have nearly enough expertise in this area to be able to tell if this is RTBC or not, sorry but it does look good :)
Comment #7
jibranWell views changes are fine. I just needed an opinion on D8MI stuff. In #4 I just updated doc and fixed a test so I think after #2, #5 and #6 It is RTBC.
Thank you @vijaycs85 and @Gábor Hojtsy for the review.
Comment #8
alexpottAdditional space.
The docblock has the arguments in the wrong order.
Comment #9
jibranFixed #8.
Comment #10
alexpott:)
Comment #11
jibranDone
Comment #12
alexpottThis issue is a major task that will improve performance and the disruption it introduces is limited. Per https://www.drupal.org/core/beta-changes, this is a good change to complete during the Drupal 8 beta phase. Committed 56e29e0 and pushed to 8.0.x. Thanks!
Fixed on commit.
Comment #14
Gábor HojtsyYay, thanks!