Bartik is about to undergo a rewrite. One real improvement would be moving the menus from the page template to blocks so we can move the menus around and select alternative menus.

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Closed (duplicate)

This is a duplicate of #2005546: Use branding block in place of page template branding variables (site name, slogan, site logo).

See also #507488: Convert page elements (local tasks, actions) into blocks

dcrocks’s picture

dcrocks commented

The menus are blocks. See #1869476: Convert global menus (primary links, secondary links) into blocks. And look at bartik's current page.html.twig.

jensimmons’s picture

jensimmons commented

+1. It's only the way it is now because that's how core templates did things in Drupal 6. Since core has evolved & improved, Bartik should too.

peterx’s picture

peterx commented

Thank you for the links. I have beta 2 installed. Still the old Bartik. I used both the Drupal search and Google to find issues but did not see either one of the issues mentioned here. I look forward to seeing the changes in beta 3. :-)

dcrocks’s picture

dcrocks commented

Didn't see the issues or the changes in the code? #1869476: Convert global menus (primary links, secondary links) into blocks was committed before beta 2. Definitely nor the old bartik.

dcrocks’s picture

dcrocks commented

Old bartik(alpha15):

   {% if secondary_menu %}
      <nav id="secondary-menu" class="navigation" role="navigation" aria-labelledby="links__system_secondary_menu">
        {{ secondary_menu }}
      </nav> <!-- /#secondary-menu -->
    {% endif %}

New Bartik(dev):

    {{ page.secondary_menu }}
peterx’s picture

peterx commented

@dcroks, I installed beta 3 before I could look at beta 2 again. I remember setting all the logo code and stuff. I will look into the beta 3 version in more detail.