Problem/Motivation

Add a date field to an entity.
Hover over the date field.
The hover text is something like "Date (i.e. 2014-09-11)"

In English, "i.e." means "that is", and "e.g." means "for example".
http://public.wsu.edu/~brians/errors/e.g.html

Proposed resolution

The hover text should use e.g. instead of i.e.
So it should be something like "Date (e.g. 2014-09-11)"

CommentFileSizeAuthor
#7 time-after-apply.png14.9 KBsarav.din33
#7 time-before-apply.png14.56 KBsarav.din33
#7 drupal-update-hover-text-for-date-time-field-2371987-7.patch1.27 KBsarav.din33
#6 date-before-apply.png6.81 KBsarav.din33
#6 date-after-apply.png19.85 KBsarav.din33
#4 date-after-apply.png107.62 KBsarav.din33
#4 date-before-apply.png104.81 KBsarav.din33
#1 drupal-2371987-1.patch808 bytesmichaellenahan
date-hover-after.png13.03 KBmichaellenahan

Comments

michaellenahan’s picture

michaellenahan commented
StatusFileSize
new drupal-2371987-1.patch808 bytes

Here is the patch.

michaellenahan’s picture

michaellenahan commented
Status: Active » Needs review
Alienpruts’s picture

Alienpruts commented

Tnx michaellenahan , looking good

sarav.din33’s picture

sarav.din33 commented
Status: Needs review » Needs work
StatusFileSize
new date-before-apply.png104.81 KB
new date-after-apply.png107.62 KB

@michaellenahan, Patch#1 is working for me.

Before patch apply,
Date before
After patch apply,
Date after

Also i have noted that, you missed out the Time hover text changes.

sarav.din33’s picture

sarav.din33 commented
sarav.din33’s picture

sarav.din33 commented
StatusFileSize
new date-after-apply.png19.85 KB
new date-before-apply.png6.81 KB
sarav.din33’s picture

sarav.din33 commented
Status: Needs work » Needs review
StatusFileSize
new drupal-update-hover-text-for-date-time-field-2371987-7.patch1.27 KB
new time-before-apply.png14.56 KB
new time-after-apply.png14.9 KB

@michaellenahan, i have noted that, you missed out the Time hover text changes.

For this i have created a patch. Please review the attached patch.

Before apply my patch:
Before time

After apply my patch:
After time

Can you please review the same.

michaellenahan’s picture

michaellenahan commented
Status: Needs review » Reviewed & tested by the community

Thanks for spotting that, @sarav.din33!
The patch looks good, setting to RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

I approve of this pedantry. :) Good eye.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed d68e2c1 on 8.0.x 
    Issue #2371987 by sarav.din33, michaellenahan: Use e.g. instead of i.e....

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.