Problem/Motivation

In the Database install task the description of the prefix field is not elegant because of not spaced hyphens. (I said it was "minor" ^^)

Allowed in beta?

This is allowed in the d8 beta https://www.drupal.org/core/beta-changes
because it is only touching a translatable string.

Proposed resolution

Add spaces.

User interface changes

Steps to reproduce:

  1. Install Drupal in graphical mode
  2. Go to the "Set up database" step
  3. Open the "Advanced options" fieldset

Before:

If more than one application will be sharing this database, a unique table name prefix–such as %prefix–will prevent collisions.

After:

If more than one application will be sharing this database, a unique table name prefix – such as %prefix – will prevent collisions.

CommentFileSizeAuthor
#1 core_database-improve_install_prefix_field_description-2371479-1.patch894 bytesduaelfr
db_install_after.png13.46 KBduaelfr
db_install_before.png13.55 KBduaelfr

Comments

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Assigned: duaelfr » Unassigned
Status: Active » Needs review
Related issues: +#2042143: [META] Fix unsafe core translatable strings
StatusFileSize
new core_database-improve_install_prefix_field_description-2371479-1.patch894 bytes

Here is the patch.

This string has been found running the script that detects untranslatable strings in core (even if this one is fully translatable, the tool also detects string containing non-ascii chars). See the related issue for more information.

yesct’s picture

yesct commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a unfrozen (ui text) change as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed 635988f and pushed to 8.0.x. Thanks!

  • alexpott committed 635988f on 8.0.x 
    Issue #2371479 by DuaelFr: Replace inelegant string in core/lib/Drupal/...
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

\o/ Thank you both!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.