EntityFieldTest delegates all the actual testing to internal assertXx() helpers.

When something fails in there, the only thing that gets reported is a fail on the top-level assert, so this is not really a good pattern for assert helpers with 200+ LoC...

CommentFileSizeAuthor
#1 2369639-EntityFieldTest-helpers-1.patch5.56 KByched

Comments

yched’s picture

yched commented
Status: Active » Needs review
StatusFileSize
new 2369639-EntityFieldTest-helpers-1.patch5.56 KB

Attached patch renames the internal helpers to something that's not assertXx().

yched’s picture

yched commented

(also removes stale use statements)

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Quick enough? :)

yched’s picture

yched commented

@amateescu : thanks ;-)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a prioritized change (test improvements) as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? and it's benefits outweigh any disruption. Committed 900d403 and pushed to 8.0.x. Thanks!

  • alexpott committed 900d403 on 8.0.x 
    Issue #2369639 by yched: EntityFieldTest helper methods makes debugging...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.