Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In #2267453: Views plugins do not store additional dependencies we added the ability for views plugins to expose their dependencies to the configuration system. This task will add dependencies from argument_validator and argument_default plugins by creating and configuring the plugins in ArgumentPluginBase::calculateDependencies() and returning the dependencies.
Comment | File | Size | Author |
---|---|---|---|
#13 | 2368767-13.patch | 18.9 KB | Wim Leers |
Comments
Comment #1
Wim LeersWe should've unpostponed this a long time ago.
Should this be critical?
Comment #2
xjmYeah there are probably config dependencies in there. :)
Comment #3
dawehnerWell, I have seen major issues which have been way more critical, anyway.
Comment #4
Wim LeersPatch looks sane. Needs tests?
Comment #6
alexpottAdded test coverage.
I looked into adding content entity dependencies for when you provide a fixed argument for something like a UID or NID. Since it is perfectly possible to put non existent IDs here and they are not converted to UUIDs I think that is beyond the scope here and might even be undesirable.
Comment #7
dawehnerYeah, the problem is that you don't even know what people might do with the number entered there. It could be that they use it for
>
comparisons, in which not validating the number as dependency would be the thing you wantComment #8
xjmSounds like validation fun time in a child issue of #2392823: [meta] Much Views UI input is not validated.
For the specific entity dependencies, I do think that's worth a followup since the 80% usecase probably is referencing a specific entity, and the default argument could be a config or content entity depending on the plugin. It might wait on the entity referencing widget bit we talked about as a followup for #2341357: Views entity area config is not deployable and missing dependencies.
Comment #9
dawehnerThank you alex for writing a test!
Let's expand the test coverage to argument validator plugins as well.
Comment #10
dawehnerForgot one new file.
Comment #12
jibranThis is beautiful and elegant imo so RTBC.
I didn't know about that.
Comment #13
Wim LeersNeither of these are used. Removed them.
Comment #14
catchCommitted/pushed to 8.0.x, thanks!