Problem/Motivation

#1822048: Introduce a generic fallback plugin mechanism was committed recently, SelectionPluginManager should use it as well.

Proposed resolution

Make SelectionPluginManager implement FallbackPluginManagerInterface and remove the custom code that handled it before.

Remaining tasks

Work on harder patches.

User interface changes

Nope.

API changes

Nope.

CommentFileSizeAuthor
#1 2368443.patch3.74 KBamateescu

Comments

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 2368443.patch3.74 KB

There we go.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Sadly the standardized solution ends up with more lines of code than the custom one, but consistency++.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a prioritized change (it is a result of #1822048: Introduce a generic fallback plugin mechanism which committed at the end of sept 2014) as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? and it's benefits outweigh any disruption. Committed bedfc1a and pushed to 8.0.x. Thanks!

  • alexpott committed bedfc1a on 8.0.x 
    Issue #2368443 by amateescu: Use the new FallbackPluginManagerInterface...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.